-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add release-binaries workflow #355
Conversation
project_path: "./cmd/lassie" | ||
binary_name: "lassie" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alternatively you can use goreleaser like the one i have set up for index-provider
CLI. That also uploads binaries to github releases amongst other stuff; example.
is goreleaser superior to this setup? I'm not really fussed as long as it works, I'd love to have consistency across projects but it seems like everyone's having a go at something different with these |
I too am not fussed. For me go releaser does more with less config; that's all. Feel free to merge this as is. |
fair enough, it is a simpler setup and the name "goreleaser" makes it feel more official... |
@@ -0,0 +1,26 @@ | |||
name: GoReleaser |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For goreleaser binary build to do the right thing in this repo a config like this is needed. Once that's added try running goreleaser check
to verify the config, and give goreleaser --rm-dist --snapshot
a shot to make sure binaries are built as you expect them to (written in dist
directory by default).
I also recommend adding dist
to .gitingore
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does more with less config
he said!
ok, added the config and tested it all out
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lol; that's the best kind of true: technically.
f162de3
to
44f8ce8
Compare
Closes: #354