Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add release-binaries workflow #355

Merged
merged 2 commits into from
Jan 30, 2023
Merged

feat: add release-binaries workflow #355

merged 2 commits into from
Jan 30, 2023

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Jan 25, 2023

Closes: #354

@rvagg rvagg requested a review from willscott January 25, 2023 04:19
Comment on lines 27 to 28
project_path: "./cmd/lassie"
binary_name: "lassie"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these change?

Copy link
Member

@masih masih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternatively you can use goreleaser like the one i have set up for index-provider CLI. That also uploads binaries to github releases amongst other stuff; example.

@rvagg
Copy link
Member Author

rvagg commented Jan 26, 2023

is goreleaser superior to this setup? I'm not really fussed as long as it works, I'd love to have consistency across projects but it seems like everyone's having a go at something different with these

@masih
Copy link
Member

masih commented Jan 27, 2023

I too am not fussed. For me go releaser does more with less config; that's all. Feel free to merge this as is.

@rvagg
Copy link
Member Author

rvagg commented Jan 27, 2023

fair enough, it is a simpler setup and the name "goreleaser" makes it feel more official...
have changed the config, ptal

@@ -0,0 +1,26 @@
name: GoReleaser
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For goreleaser binary build to do the right thing in this repo a config like this is needed. Once that's added try running goreleaser check to verify the config, and give goreleaser --rm-dist --snapshot a shot to make sure binaries are built as you expect them to (written in dist directory by default).

I also recommend adding dist to .gitingore.

Copy link
Member Author

@rvagg rvagg Jan 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does more with less config

he said!

ok, added the config and tested it all out

Copy link
Member

@masih masih Jan 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol; that's the best kind of true: technically.

@rvagg rvagg merged commit c839519 into master Jan 30, 2023
@rvagg rvagg deleted the rvagg/release-binaries branch January 30, 2023 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🎉 Done
Development

Successfully merging this pull request may close these issues.

Create executable binaries for every release
3 participants