deps(cmd): update go-internal dependency #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willscott
approved these changes
Feb 8, 2023
|
Yeah, I'm afraid that's a weird but known bug for testscript on macos-12. See rogpeppe/go-internal#200. Downgrading to macos-11 is the only workaround I'm aware of, right now. I wrote all the details I know on that thread, so if any of you have a hunch or can investigate further on a MacOS 12 machine, that would be appreciated :) |
|
great, thanks for looking @mvdan and for the ping in that thread, I'll watch progress and if I come up with any insights I'll chime in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Crossing my fingers and attempting to fix the new flaky macos CI failures for testing the cmd package. I can replicate it locally after enough test re-runs and haven't been able to replicate it with this update, but it's flaky so that doesn't prove anything.
@mvdan are you aware of anything that might be coming out of testscript that's causing flaky CI executions on macos-only? We see them pretty regularly now, e.g.:
They all have the pattern:
where the the script varies, i.e. it happens across different scripts, just on macos.