perf: reduce NewCarReader allocations #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This accounted for almost 10% of the garbage on one of Bluesky's
server daemons (go tool pprof --alloc_space), leading to high GC CPU.
benchstat:
│ before │ after │
│ sec/op │ sec/op vs base │
NewCarReader_small-8 2.005µ ± 1% 1.451µ ± 5% -27.61% (p=0.000 n=10)
│ before │ after │
│ B/op │ B/op vs base │
NewCarReader_small-8 5.268Ki ± 0% 1.135Ki ± 0% -78.46% (p=0.000 n=10)
│ before │ after │
│ allocs/op │ allocs/op vs base │
NewCarReader_small-8 29.00 ± 0% 27.00 ± 0% -6.90% (p=0.000 n=10)
bradfitz
requested review from
rvagg,
willscott,
masih and
hannahhoward
as code owners
rvagg
approved these changes
May 9, 2023
bradfitz
added a commit
to bradfitz/indigo
that referenced
this pull request
May 10, 2023
Updates github.com/ipld/go-car to the latest commit to bring in ipld/go-car#420 which should drop allocated bytes (garbage that triggers the GC to spend CPU) by about 9%.
bnewbold
pushed a commit
to bluesky-social/indigo
that referenced
this pull request
May 10, 2023
Updates github.com/ipld/go-car to the latest commit to bring in ipld/go-car#420 which should drop allocated bytes (garbage that triggers the GC to spend CPU) by about 9%.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This accounted for almost 10% of the garbage on one of Bluesky's server daemons (go tool pprof --alloc_space), leading to high GC CPU.
benchstat: