Support go-multihash hashing in LinkSystem #145
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals
This is a strawman proposal for how to solve our various incompatibilities between go-multihash and the desire to write a new system for go-ipld-prime.
Per #143 (comment) -- it sounds like there is a desire to do a ground up rethink of go-multihash. We don't want to block that effort, but we also need to use go-multihash and go-cid to insure compatibility as we integrate IPLD prime in IPFS. Per #143 (comment) & #143 (comment) there is really no gaurantee a new system will work with all existing IPFS code without a lot of effort, and we don't want to undertake that now.
So, this is a proposal to allow for a rewrite while still allowing access to the tables in go-multihash should you want them. It also includes one change to go-multihash and one change to go-cid to enable this.
Implementation
For discussion
I'm not sure this is the right final solution, or even a great one. However, I'm gonna officially say "my work here is done" -- because I am not a steward of go-multihash or go-cid, and I think at this point @warpfork and @Stebalien should decide a long term plan together and whether this works well for now.