Bindnode fixes of opportunity #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvdan
approved these changes
Aug 14, 2021
Also some other improvements marked for future work. (I'm accumulating fixes and/or todos in patch form, as I try to use bindnode as a downstream user. These may not be the highest quality patches, but it's better to strike as things are discovered than not.)
…look for a potentially complex type as the recipient.
…elimiter. In this case, the parsing checks each complete prefix. Errors are also returned when data is nonmatching, rather than panicking.
Perhaps these read better? I think there will be better results in the future from pursuing well-structured errors. This prose feels stilted because it's pretending to have some consistent structure (what kind of error? a failure of schema to unify data. one what type? this one. of what detailed reason? yada yada. Etc). If we actually had that consistent structure: that would be an improvement.
warpfork
force-pushed
the
bindnode-fixes-of-opportunity
branch
from
ec501fa
to
a34aaee
Compare
|
Took all suggestions. (Though I'm not sure I favour prioritizing error message brevity much, at the moment. So far, my experience as a user is that I want more info approximately 100% of the time, and I'd much rather get clarity at the expense of brevity. But, that said, we're also still at the "printf" stage of development on any of the errors, so I'm going to hope things are improved in general in future passes that make error handling more structured.) |
|
Gonna enthusiastically merge this, more can come later :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A variety of error message improvements and polish as diffs.
I'm trying to just track these things and do target-of-opportunity work as I try to be a downstream user. The commit messages still say what and why, but the focus is... whatever I hit. :)