storage: add 'RWStorage' grouping interface. #277
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've come to think this is a bad idea. The I'm gonna drop this diff. |
warpfork
added a commit
that referenced
this pull request
Oct 25, 2021
I came to see this as avoidable; and the fact that >50% of the docs on the type were admonishments about when _not_ to use it was a bad sign. This pattern could be a way to use to avoid needing a RW interface: `func MyRWConstructor(...your params here...) (ReadableStorage, WritableStorage, error)`. Or in other words: using multiple returns, each with the relevant type, keeps things nicely similar to how we'll expect to continue passing them around separately thereafter. Also briefly discussed as a PR at #277 .
|
I think I'd like to have a single object so that it's clear that it's the same store that where reads after writes will reflect what was written earlier. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feedback requested. I'm dubious about this one.
I've sometimes felt the desire to make a constructor function that -- like the doc in the diff describes -- returns an interface, not a concrete type, and happens to implement both the reading and the writing features at the same time. Then, one wants that type to also be immediately ready to pass to any of the other functions that expect
ReadableStorageorWritableStorage. This combined interface would allow that.On the other hand: this feels weird, because I spent >50% of the docs text saying when one shouldn't use this interface. Maybe we shouldn't introduce this interface, and instead should provide documentation recommending a pattern of
func MyRWConstructor(...your params here...) (ReadableStorage, WritableStorage, error)that uses multiple returns in a way that's symmetric to how we pass them around separately elsewhere.Thoughts?