-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: map/list interfaces #451
Conversation
Copying over some of your comments and my responses, @RangerMauve, so that the full discussion is in one place.
|
Closing this PR for now until (if at all) it makes sense to pick back up. I'd like to take this over the finish line but don't want to add work unnecessarily. |
This depends on #445.
Experimental changes for more usable
map
andlist
interfaces for IPLD nodes, based on amend.This is an attempt to:
amend
brings.Once a reasonable interface is established, it can be extended to other recursive types/ADLs like
go-ipld-adl-hamt
, that are also quite inconvenient (or impossible) to use like normal maps/lists.I wanted to get some early feedback so only the
map
interface is implemented. The tests inmap_test.go
demonstrate some ways in which the interface can be used.Supersedes this PR.
cc @RangerMauve @rvagg @aschmahmann @BigLep @warpfork