refactor for multiformats #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: make clean Uint8Array
Not strictly necessary but this test was added to ipld-dag-cbor and it's nice for completeness and holds us strictly to the promise of Uint8Arrays being the primary byte holder Ref: ipld/js-ipld-dag-cbor#129
chore: pull in Uint8Array|Buffer test
rvagg
reviewed
Jun 12, 2020
index.js
Outdated
| return deserialized | ||
| } | ||
|
|
||
| const code = 0x71 |
There was a problem hiding this comment.
tiny nit: could we pull these two to the top level and at the top of the file?
There was a problem hiding this comment.
good catch, i agree.
rvagg
approved these changes
Jun 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.