fix!: decode large non-safe numbers with no decimal as BigInt #46
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heads up @achingbrain, this is going to make dag-json do the same thing that dag-cbor does, returns
BigInt
when you're outside of safe integer range. We're currently in a lossy situation with those numbers, but with this change we get to safely pull the integer out as it is in the encoded JSON.But, it's a breaking change because previously it's all just
Number
.BREAKING CHANGE
Because previously, all numbers just get decoded as
Number
, after thischange any number in the JSON that doesn't have a decimal place and is
outside of the JavaScript safe integer range will be provided as a
BigInt
.