Skip to content
This repository has been archived by the owner on Dec 6, 2022. It is now read-only.

feat: use class-is module for type checks #39

Merged
merged 1 commit into from
Apr 9, 2018

Conversation

fsdiogo
Copy link
Contributor

@fsdiogo fsdiogo commented Mar 28, 2018

This is an ongoing effort to fix the ipfs/js-ipfs#938 issue.

It uses a module I've published that abstracts this solution: ipfs/js-ipfs#1131 (comment).

@fsdiogo fsdiogo requested a review from daviddias March 28, 2018 15:21
@ghost ghost assigned fsdiogo Mar 28, 2018
@ghost ghost added the status/in-progress In progress label Mar 28, 2018
@fsdiogo fsdiogo force-pushed the feat/use-class-is-module-for-type-checks branch from a5fb038 to 1c6e541 Compare April 2, 2018 09:34
@fsdiogo fsdiogo force-pushed the feat/use-class-is-module-for-type-checks branch from 1c6e541 to 8f83291 Compare April 9, 2018 09:47
Copy link
Member

@daviddias daviddias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daviddias daviddias merged commit 958cd09 into master Apr 9, 2018
@ghost ghost removed the status/in-progress In progress label Apr 9, 2018
@daviddias daviddias deleted the feat/use-class-is-module-for-type-checks branch April 9, 2018 15:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants