Skip to content
This repository has been archived by the owner on Aug 11, 2021. It is now read-only.

Interop with Go got broken (now fixed by unpublishing latest patch version) #41

Closed
daviddias opened this issue Sep 5, 2017 · 3 comments
Labels
kind/bug A bug in existing code (including security flaws)

Comments

@daviddias
Copy link
Member

I completely missed this comment #39 (comment) and given this issue reported here https://github.com/ipld/js-ipld-dag-pb/pull/39/files#r137020214, now two objects created with the same data and or links will have different hashes between go and js. As expected, this is not ok.

As an interim solution, I'll unpublish the latest version and will publish again once everything needed for ipfs/js-ipfs#991 is ready.

@daviddias daviddias changed the title Interop with Go is broken Interop with Go got broken (now fixed by unpublishing latest patch version) Sep 5, 2017
@daviddias daviddias added the kind/bug A bug in existing code (including security flaws) label Sep 5, 2017
@dignifiedquire
Copy link
Member

there is an easier quick fix, you can change the generated file manually to match

@dignifiedquire
Copy link
Member

Probably need to recheck the other modules as well..

@daviddias
Copy link
Member Author

Only two got released from the list ipfs/js-ipfs#991. I unpublished those 2 patch versions. Let's finish the endeavour, make sure everything is ready and super tested (all the way to js-ipfs running js-ipfs interop tests) and then we will merge.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug A bug in existing code (including security flaws)
Projects
None yet
Development

No branches or pull requests

2 participants