This repository has been archived by the owner on Aug 11, 2021. It is now read-only.
fix: switch to protobufjs #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no need for eval anymore
This was referenced Sep 4, 2017
daviddias
suggested changes
Sep 5, 2017
| @@ -38,3 +38,6 @@ test/repo-just-for-test* | |||
|
|
|||
| # Vim .swp files | |||
| **.swp | |||
|
|
|||
| package-lock.json | |||
| yarn.lock | |||
There was a problem hiding this comment.
Missing to .gitignore the generated file.
daviddias
approved these changes
Sep 5, 2017
daviddias
reviewed
Sep 5, 2017
| expect(nodeJSON.multihash).to.eql('QmQqy2SiEkKgr2cw5UbQ93TtLKEMsD8TdcWggR8q9JabjX') | ||
| // multihash is different (original: QmQqy2SiEkKgr2cw5UbQ93TtLKEMsD8TdcWggR8q9JabjX) | ||
| // because the libraries order data and links differently, but this doesn't affect functionality | ||
| expect(nodeJSON.multihash).to.eql('QmNiSwLd6tmtmm3KQJbVmMhQbyZNU8TSSzDG31JTkcSLeN') |
There was a problem hiding this comment.
It breaks interoperability. My bad not reading this note.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no need for eval anymore