Skip to content
This repository has been archived by the owner on Aug 11, 2021. It is now read-only.

Resolving Link Name and/or Tsize #85

Closed
alanshaw opened this issue Aug 26, 2018 · 2 comments · Fixed by #86
Closed

Resolving Link Name and/or Tsize #85

alanshaw opened this issue Aug 26, 2018 · 2 comments · Fixed by #86
Labels
kind/bug A bug in existing code (including security flaws) status/ready Ready to be worked

Comments

@alanshaw
Copy link
Member

Is this code correct?

js-ipld-dag-pb/src/resolver.js

Lines 61 to 64 in aa6274c

} else if (split[2] === 'Tsize') {
value = { '/': value.size }
} else if (split[2] === 'Name') {
value = { '/': value.name }

The resolved value is { "/": "name.txt" } or { "/": 12345 } - shouldn't it only have the object with slash property wrapper if it's a link?
@daviddias daviddias added the kind/bug A bug in existing code (including security flaws) label Aug 27, 2018
@daviddias
Copy link
Member

daviddias commented Aug 27, 2018 •
edited
Loading

Yeah, that's a bug, good catch! @alanshaw can you write tests for these and a PR with a fix?

@daviddias daviddias added the status/ready Ready to be worked label Aug 27, 2018
@alanshaw
Copy link
Member Author

alanshaw commented Aug 28, 2018 •
edited
Loading

Yep! - #86

alanshaw added a commit that referenced this issue Aug 28, 2018
@alanshaw
fix: resolve link Name or Tsize
d8caa3f 
Resolve to the value of Name or Tsize, do not wrap in IPLD link object.

fixes #85

License: MIT
Signed-off-by: Alan Shaw <alan@tableflip.io>
@alanshaw alanshaw mentioned this issue Aug 28, 2018
Merged
@vmx vmx closed this as completed in #86 Sep 11, 2018
vmx pushed a commit that referenced this issue Sep 11, 2018
@alanshaw @vmx
fix: resolve link Name or Tsize
981cb9f 
Resolve to the value of Name or Tsize, do not wrap in IPLD link object.

fixes #85

License: MIT
Signed-off-by: Alan Shaw <alan@tableflip.io>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
kind/bug A bug in existing code (including security flaws) status/ready Ready to be worked
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: resolve link Name or Tsize ipld/js-ipld-dag-pb
2 participants
@alanshaw @daviddias