Skip to content
This repository has been archived by the owner on Aug 11, 2021. It is now read-only.

fix: remove node globals #175

Merged
merged 6 commits into from
Apr 21, 2020
Merged

fix: remove node globals #175

merged 6 commits into from
Apr 21, 2020

Conversation

hugomrdias
Copy link
Member

@hugomrdias hugomrdias commented Mar 25, 2020

This PRs cleans ups old stuff and removes node globals

ref:
ipfs/js-ipfs#2924

@codecov
Copy link

codecov bot commented Mar 25, 2020

Codecov Report

Merging #175 into master will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #175      +/-   ##
==========================================
+ Coverage   96.13%   96.20%   +0.07%     
==========================================
  Files          15       15              
  Lines         207      211       +4     
==========================================
+ Hits          199      203       +4     
  Misses          8        8              
Impacted Files Coverage Δ
src/dag-link/dagLink.js 91.66% <100.00%> (+0.36%) ⬆️
src/dag-node/dagNode.js 91.66% <100.00%> (+0.17%) ⬆️
src/dag-node/rmLink.js 90.00% <100.00%> (+1.11%) ⬆️
src/dag-node/sortLinks.js 100.00% <100.00%> (ø)
src/util.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79adbe8...fd84a91. Read the comment docs.

Copy link
Member

@vmx vmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the note, let me know when it is ready to merge.

@hugomrdias hugomrdias force-pushed the fix/remove-node-globals branch from 145a4a0 to fd84a91 Compare April 20, 2020 18:34
@hugomrdias hugomrdias requested a review from vmx April 20, 2020 18:40
@vmx vmx merged commit d965ba3 into master Apr 21, 2020
@vmx vmx deleted the fix/remove-node-globals branch April 21, 2020 08:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants