This repository has been archived by the owner on Aug 11, 2021. It is now read-only.
refactor: incorporate eth-hash-to-cid module #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `eth-hash-to-cid` module is only used by this repository. To lower the maintenance burden of having a separate module, incorporate it into this repository. This also opened up the chance to rename it to `cidFromHash` which was already the name used internally.
Closed
daviddias
approved these changes
Jul 2, 2018
daviddias
reviewed
Jul 2, 2018
| @@ -1,6 +1,6 @@ | |||
| 'use strict' | |||
| const EthAccount = require('ethereumjs-account') | |||
| const cidFromHash = require('eth-hash-to-cid') | |||
| const cidFromHash = require('../util/cidFromHash') | |||
There was a problem hiding this comment.
please use the convention of - instead of Camel Case for filenames.
There was a problem hiding this comment.
I did it in favour of consistency. All files in util are camel case.
There was a problem hiding this comment.
favor consistency across modules.
There was a problem hiding this comment.
Generally yes, but in this case favour local consistency. I've opened an issue for global consistency: #20
|
Addressed the review comment in a different way. Hence I dare to merge it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
eth-hash-to-cidmodule is only used by this repository.To lower the maintenance burden of having a separate module,
incorporate it into this repository.
This also opened up the chance to rename it to
cidFromHashwhichwas already the name used internally.