Skip to content
This repository has been archived by the owner on Aug 11, 2021. It is now read-only.

feat: .get(<array of CIDs>) #132

Closed
daviddias opened this issue Jun 4, 2018 · 5 comments
Closed

feat: .get(<array of CIDs>) #132

daviddias opened this issue Jun 4, 2018 · 5 comments
Assignees
Labels
exp/novice Someone with a little familiarity can pick up P0 Critical: Tackled by core team ASAP

Comments

@daviddias
Copy link
Member

daviddias commented Jun 4, 2018

We need an endpoint for https://github.com/ipfs/js-ipfs-unixfs-engine that can return multiple IPLD nodes from an Array of CIDs.

Leverage ipfs/js-ipfs-block-service#81

This is blocking ipfs/js-ipfs#856.

@vmx do you already have code for this with the GraphSync endeavour?

@daviddias daviddias added the P0 Critical: Tackled by core team ASAP label Jun 4, 2018
@vmx
Copy link
Member

vmx commented Jun 6, 2018

I think it would make sense to put this into Bitswap. Though I'm not sure if that will be easy (the way Bitswap works today). I don't have usable code for this.

@daviddias daviddias added the status/ready Ready to be worked label Jun 19, 2018
@daviddias
Copy link
Member Author

daviddias commented Oct 27, 2018

This already exists on Bitswap. We need it here to trickle it down. This is needed for ipfs/js-ipfs#856 and should be quick to implement

I made a graph to explain today's architecture ipfs/js-ipfs#1673 it should help understand how the ask for the multiple CIDs gets trickled.

@daviddias daviddias added the exp/novice Someone with a little familiarity can pick up label Oct 27, 2018
@daviddias
Copy link
Member Author

@vmx this is labeled as P0 Critical since Jun 4, it should be a simple change. Do you disagree with the priority? Feel free to adjust the label.

@vmx
Copy link
Member

vmx commented Nov 6, 2018

@diasdavid This slipped my attention, I'll have a look. thanks for pinging.

@daviddias
Copy link
Member Author

@vmx develop the habit at checking the waffle board and use filters to help you understand what is top priority (and also to communicate to others). https://waffle.io/ipld/js-ipld

https://waffle.io/ipld/js-ipld?label=P0%20-%20Critical

image

https://waffle.io/ipld/js-ipld?label=P1%20-%20High

image

@vmx vmx self-assigned this Nov 7, 2018
vmx added a commit that referenced this issue Nov 7, 2018
With `getMany()` it's possible to get several blocks with one call.

Closes #132.
@ghost ghost added status/in-progress In progress and removed status/ready Ready to be worked labels Nov 7, 2018
vmx added a commit that referenced this issue Nov 7, 2018
With `getMany()` it's possible to get several blocks with one call.

Closes #132.
vmx added a commit that referenced this issue Nov 7, 2018
With `getMany()` it's possible to get several blocks with one call.

Closes #132.
@vmx vmx closed this as completed in #177 Nov 7, 2018
vmx added a commit that referenced this issue Nov 7, 2018
With `getMany()` it's possible to get several blocks with one call.

Closes #132.
@ghost ghost removed the status/in-progress In progress label Nov 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
exp/novice Someone with a little familiarity can pick up P0 Critical: Tackled by core team ASAP
Projects
None yet
Development

No branches or pull requests

2 participants