-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace prost
with quick-protobuf
#168
Comments
The current DAG-PB version is not spec compliant. The proper fix would be to do the same as the JS implementation and the Go implementation and just encode and decode manually, so no need for a protocol buffers library would be needed. Both implementations can serve as a template, depending on whether someone prefers JS or Go. AFAICT libipld currently doesn't need |
There is still a dependency on |
That's a lot more work though. |
The DAG-PB codec is now spec compliant. The fixtures at https://github.com/ipld/codec-fixtures pass. Closes #168,#139
Currently rust-libp2p and iroh are working on getting rid of the need for
protoc
in its builds. The current plan is to switch toquick-protobuf
.For iroh it would be very useful if libipld switched too, as we otherwise need to avoid parts of libipld.
Refs:
protoc
toquick-protobuf
and remove the buildscripts libp2p/rust-libp2p#3024protoc
toquick-protobuf
n0-computer/beetle#67The text was updated successfully, but these errors were encountered: