Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace prost with quick-protobuf #168

Closed
dignifiedquire opened this issue Nov 23, 2022 · 3 comments · Fixed by #170
Closed

Replace prost with quick-protobuf #168

dignifiedquire opened this issue Nov 23, 2022 · 3 comments · Fixed by #170

Comments

@dignifiedquire
Copy link
Member

Currently rust-libp2p and iroh are working on getting rid of the need for protoc in its builds. The current plan is to switch to quick-protobuf.

For iroh it would be very useful if libipld switched too, as we otherwise need to avoid parts of libipld.

Refs:

@vmx
Copy link
Member

vmx commented Nov 23, 2022

The current DAG-PB version is not spec compliant. The proper fix would be to do the same as the JS implementation and the Go implementation and just encode and decode manually, so no need for a protocol buffers library would be needed. Both implementations can serve as a template, depending on whether someone prefers JS or Go.

AFAICT libipld currently doesn't need protoc as we've checked in the generated file.

@dignifiedquire
Copy link
Member Author

AFAICT libipld currently doesn't need protoc as we've checked in the generated file.

There is still a dependency on prost which I would like to drop.

@dignifiedquire
Copy link
Member Author

The current DAG-PB version is not spec compliant. The proper fix would be to do the same as the JS implementation and the Go implementation and just encode and decode manually, so no need for a protocol buffers library would be needed. Both implementations can serve as a template, depending on whether someone prefers JS or Go.

That's a lot more work though.

dignifiedquire added a commit that referenced this issue Dec 2, 2022
@vmx vmx closed this as completed in #170 Jan 9, 2023
vmx pushed a commit that referenced this issue Jan 9, 2023
The DAG-PB codec is now spec compliant. The fixtures
at https://github.com/ipld/codec-fixtures pass.

Closes #168,#139
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants