Gather and report metrics on lookup success and broadcasting #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willscott
reviewed
Mar 21, 2023
willscott
approved these changes
Mar 21, 2023
Implement prometheus metrics to report information on * lookup success rate * lookup result count * lookup latency * lookup time to first provider * broadcaster end-to-end latency * broadcaster in-flight messages * broadcaster message batch size * broadcaster success/skipped/failure rate * receiver connected peers count * receiver error rate The changes here also implement: * optional filtering of non-public addrs * uniqueness check on found providers within a lookup response Fixes #6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement prometheus metrics to report information on
The changes here also implement:
Fixes #6