Implement configurable provider record caching #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement caching mechanism where the entire found provider record is cached regardless of the peerstore state. Use an adaptive 2Q cache heuristic where burst of unseen keys will not impact popular cache entries.
willscott
approved these changes
Jun 13, 2023
masih
added a commit
to ipni/storetheindex
that referenced
this pull request
Jun 13, 2023
Set cache expiry to 24 hours with cache size of 1M. The caching memory footprint is unclear just now. Further experimentation is needed to right-size the instance relative to cache size. Use a reduced cache expiry and size for `dev` environment. See: - ipni/cassette#38
masih
added a commit
to ipni/storetheindex
that referenced
this pull request
Jun 13, 2023
Set cache expiry to 24 hours with cache size of 1M. The caching memory footprint is unclear just now. Further experimentation is needed to right-size the instance relative to cache size. Use a reduced cache expiry and size for `dev` environment. See: - ipni/cassette#38
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement caching mechanism where the entire found provider record is cached regardless of the peerstore state.
Use an adaptive 2Q cache heuristic where burst of unseen keys will not impact popular cache entries.