Count HTTP delegated routing calls by method and return 501 on PUT
#55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Count the number of calls made to the HTTP delegated routing tagged by method. Explicitly return `501 Not Implemented` on `PUT` to `/routing/v1/providers`. This is to identify that putting provider records is not currently implemented by `cid.contact`. Relates to: - ipfs/specs#337 (comment) Fixes #54
masih
force-pushed
the
masih/metrics_http_deleg_routing_method
branch
from
9b035cf to
44cab9f
Compare
3 tasks
willscott
approved these changes
Dec 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Count the number of calls made to the HTTP delegated routing tagged by method.
Explicitly return
501 Not ImplementedonPUTto/routing/v1/providers. This is to identify that putting provider records is not currently implemented bycid.contact.Relates to:
Fixes #54