Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old addresses from peerstore #2299

Merged
merged 3 commits into from
Sep 27, 2023
Merged

Remove old addresses from peerstore #2299

merged 3 commits into from
Sep 27, 2023

Conversation

gammazero
Copy link
Collaborator

@gammazero gammazero commented Sep 27, 2023

When a publisher's address changes, the new address(es) are added to the peerstore, and the old ones are left alone. This causes the old address remain in the peer info and be used for polling. Frequent polling of manual syncs can keep the old invalid address around indefinitely.

This PR fixes this by applying the fix here: ipni/go-libipni#127

The updates to go-libipni and go-indexer-core also reduce log noise by removing, or logging at debug level, some non-important log messages.

@gammazero gammazero marked this pull request as ready for review September 27, 2023 12:36
@codecov-commenter
Copy link

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (72f2a8e) 46.62% compared to head (a00aa04) 46.64%.
Report is 2 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2299      +/-   ##
==========================================
+ Coverage   46.62%   46.64%   +0.02%     
==========================================
  Files          84       84              
  Lines        9953     9953              
==========================================
+ Hits         4641     4643       +2     
+ Misses       4778     4776       -2     
  Partials      534      534              
Files Coverage Δ
internal/ingest/linksystem.go 67.44% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gammazero gammazero merged commit 39c6b58 into main Sep 27, 2023
@gammazero gammazero deleted the clear-peerstore branch September 27, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants