Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: docker image not built for release tags #14

Open
lidel opened this issue Dec 5, 2024 · 3 comments
Open

ci: docker image not built for release tags #14

lidel opened this issue Dec 5, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@lidel
Copy link
Contributor

lidel commented Dec 5, 2024

Problem

CI job is not triggered on tag creation due to github's limitation, so we don't have ghcr.io/ipshipyard/p2p-forge:v0.1.0
Potential fix is to use PAT from a bot that has write permission to this repo.

Workaround for now

We have images for commit in main branch (ghcr.io/ipshipyard/p2p-forge:main-2024-11-27-a588b19 matching tag v0.1.0) as a workaround

@lidel lidel added the bug Something isn't working label Dec 5, 2024
@lidel
Copy link
Contributor Author

lidel commented Dec 5, 2024

@galargh are you able to set UCI_GITHUB_TOKEN in this repo,
like we have in https://github.com/ipfs/rainbow/ ? 🙏

(my understanding is that is why tag created by CI job does not trigger workflow on that tag -- by default job cant trigger other jobs, but if custom token is used, then it works again)

@lidel
Copy link
Contributor Author

lidel commented Dec 9, 2024

Token set, let's wait for next release.

lidel added a commit that referenced this issue Dec 19, 2024
@lidel
Copy link
Contributor Author

lidel commented Dec 19, 2024

lidel added a commit that referenced this issue Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant