Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coredns: load only used directives #3

Closed
lidel opened this issue Sep 13, 2024 · 0 comments · Fixed by #21
Closed

coredns: load only used directives #3

lidel opened this issue Sep 13, 2024 · 0 comments · Fixed by #21

Comments

@lidel
Copy link
Contributor

lidel commented Sep 13, 2024

We load everything, which is fine for prototyping, but it makes binary 100MiB in size:

_ "github.com/coredns/coredns/core/plugin" // Load all managed plugins in github.com/coredns/coredns.

Once we figure out which directives are used, we can drop the rest by importing only used ones and passing a static slice to dnsserver.Directives
lidel added a commit that referenced this issue Dec 12, 2024
@lidel
refactor: remove unused plugins
785ff75 
Decreases binary size from 105MiB to 54MiB

Closes #3
@lidel lidel mentioned this issue Dec 12, 2024
Merged
lidel added a commit that referenced this issue Dec 12, 2024
@lidel
refactor: remove unused plugins
7a082c0 
Decreases binary size from 105MiB to 54MiB

Closes #3
lidel added a commit that referenced this issue Dec 12, 2024
@lidel
refactor: remove unused plugins
2abf7cf 
Decreases binary size from 105MiB to 54MiB

Closes #3
@lidel lidel closed this as completed in #21 Dec 12, 2024
@lidel lidel closed this as completed in 448a2d9 Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: remove unused plugins ipshipyard/p2p-forge
1 participant
@lidel