Require MAX_INITCODE_SIZE limit to be satisfied during validation #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I agree. |
7 tasks
|
Just got an answer from Solidity, that limiting to MAX_INITCODE_SIZE is not an issue from their POV |
|
Opening an EIPs PR for this and #128, as well as putting adding EEST tests on my list. |
pdobacz
added a commit
to pdobacz/EIPs
that referenced
this pull request
Jun 13, 2024
pdobacz
added a commit
to ipsilon/execution-spec-tests
that referenced
this pull request
Jun 14, 2024
pdobacz
added a commit
to pdobacz/EIPs
that referenced
this pull request
Jun 17, 2024
pdobacz
added a commit
to ipsilon/execution-spec-tests
that referenced
this pull request
Jun 17, 2024
This was referenced Jun 17, 2024
pdobacz
added a commit
to pdobacz/EIPs
that referenced
this pull request
Jun 17, 2024
pdobacz
added a commit
to ipsilon/execution-spec-tests
that referenced
this pull request
Jun 20, 2024
pdobacz
added a commit
to ipsilon/execution-spec-tests
that referenced
this pull request
Jun 20, 2024
pdobacz
added a commit
to ipsilon/execution-spec-tests
that referenced
this pull request
Jun 24, 2024
pdobacz
added a commit
to ethereum/evmone
that referenced
this pull request
Jun 26, 2024
pdobacz
added a commit
to ipsilon/execution-spec-tests
that referenced
this pull request
Jun 27, 2024
marioevz
added a commit
to ethereum/execution-spec-tests
that referenced
this pull request
Jun 27, 2024
* new(tests): EOF - EIP-3540 container size Tests ipsilon/eof#125 * fix(tests): Adjust to container size limit * Update tests/prague/eip7692_eof_v1/eip3540_eof_v1/test_container_size.py * Update tests/prague/eip7692_eof_v1/eip7480_data_section/test_code_validation.py * fix(tests): import --------- Co-authored-by: Mario Vega <marioevz@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pushing in form of a PR after discussion during EOF implementers call 49.
To reiterate the reasoning behind:
Synopsis of the problem:
validate_eofand handling the containers/headers must make assumptions about the maximum size of the container to expect and handleProposal
Introduce a validation rule of max top-level container size of MAX_INITCODE_SIZE 48K (or twice that constant, for practical reasons like solidity testing methods). Whenever either the bytestring being the top-level container or the declared (in the header, as discovered during header parsing) size of the top-level container exceed that, validation fails.