Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update test links and testing readiness in implementation matrix #83

Merged
merged 3 commits into from
Apr 3, 2024
Merged

Update test links and testing readiness in implementation matrix #83

merged 3 commits into from
Apr 3, 2024

Conversation

gumb0
Copy link
Contributor

@gumb0 gumb0 commented Apr 2, 2024

No description provided.

@gumb0 gumb0 requested review from hugo-dc and pdobacz April 2, 2024 13:20
pdobacz
pdobacz approved these changes Apr 2, 2024
View reviewed changes
Copy link
Member

@pdobacz pdobacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but don't we need ethereum/tests#1350 ethereum/tests#1353 and ethereum/tests#1355 on top of this to consider tests ticked off for 3540 and 7069?

@gumb0
Copy link
Contributor Author

gumb0 commented Apr 2, 2024

LGTM, but don't we need ethereum/tests#1350 ethereum/tests#1353 and ethereum/tests#1355 on top of this to consider tests ticked off for 3540 and 7069?

I'm not sure, I think they only fix incompatibilities in tests on master, but don't add any new tests for specific features? So it's like "fix pending" and not "tests writing in progress", but I also don't want to complicate the table with the 4th kind of status...

(The plan I think is to incorporate these PRs into ethereum/tests#1349)

@pdobacz
Copy link
Member

pdobacz commented Apr 2, 2024

I'm not sure, I think they only fix incompatibilities in tests on master, but don't add any new tests for specific features? So it's like "fix pending" and not "tests writing in progress", but I also don't want to complicate the table with the 4th kind of status...

(The plan I think is to incorporate these PRs into ethereum/tests#1349)

Ah that makes sense 👍, I don't think they add new tests

@gumb0 gumb0 merged commit 83e5f6a into main Apr 3, 2024
2 checks passed
@gumb0 gumb0 deleted the update-tests-links branch April 3, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdobacz pdobacz pdobacz approved these changes

@hugo-dc hugo-dc Awaiting requested review from hugo-dc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gumb0 @pdobacz