Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FYI] Script to run template generation against topology test cases #1490

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

jbemmel
Copy link
Collaborator

@jbemmel jbemmel commented Nov 4, 2024

Not to be merged as-is, but wanted to share some interesting issues:

  • "Fatal error in netlab: libvirt is not installed" - not as fatal as it is made out to be, exit code is 0 (and libvirt isn't needed to generate output files only)
  • 14 total cases of "failed=1"
  • 8 cases of "Executing Ansible playbook failed"
Creating configs based on topology/input/unmanaged-device.yml...
Traceback (most recent call last):
  File "/home/jeroen/Projects/netlab/netlab", line 14, in <module>
    netsim.cli.lab_commands(__file__)
  File "/home/jeroen/Projects/netlab/netsim/cli/__init__.py", line 351, in lab_commands
    mod.run(sys.argv[arg_start:])   # type: ignore
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/jeroen/Projects/netlab/netsim/cli/create.py", line 93, in run
    output_module.write(topology)
  File "/home/jeroen/Projects/netlab/netsim/outputs/provider.py", line 35, in write
    providers.mark_providers(topology)
  File "/home/jeroen/Projects/netlab/netsim/providers/__init__.py", line 333, in mark_providers
    l.provider[node.provider] = True
    ~~~~~~~~~~^^^^^^^^^^^^^^^
  File "box/box.py", line 667, in box.box.Box.__setitem__
  File "box/box.py", line 386, in box.box.Box.__hash__
box.exceptions.BoxTypeError: unhashable type: "Box"

@jbemmel jbemmel marked this pull request as draft November 4, 2024 11:11
@ipspace
Copy link
Owner

ipspace commented Nov 4, 2024

Nice idea.

However, those topologies were never meant to be used to generate configurations, and if we use "device: none" just so we don't change test results when a particular device changes image name, you cannot expect the configurations to work correctly, can you?

As for "Fatal error in netlab: libvirt is not installed", did you investigate which command displays that? Also, how do you know the exit code is zero?

Anyway, the crash is worth investigating.

@jbemmel
Copy link
Collaborator Author

jbemmel commented Nov 25, 2024

Someone else found and fixed that one crash: #1552

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants