Removing many rendition properties from the ninjs 3.0 draft #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
are focusing on properties that were already in ninjs 2.1 or are required for DPP LPX.
bquinn
changed the title
iyoung
approved these changes
Sep 16, 2024
There was a problem hiding this comment.
This looks good to me @bquinn , aligning with the DPP LPX minimum required changes to renditions. A number of suggested non SRT fields have also been removed in this change, I just want to check that's intentional presumably for further discussion before they're included?
as discussed with Brendan adding back in poi
|
I've added POI back in as discussed @bquinn if there's nothing else on this I think we can get this merged to tidy up the renditions. I added a comment on #164 (comment) |
|
LGTM. All tests pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now we are focusing on properties that were already in ninjs 2.1 or are required for DPP LPX. Fixes #189 and #194.