Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(planned-coverage): remove g2 refs and unclear properties #198

Merged
merged 3 commits into from
Oct 1, 2024

Conversation

iyoung
Copy link
Contributor

@iyoung iyoung commented Sep 30, 2024

remove properties carried over which had placeholder values

remove properties carried over which had placeholder values
added back in type but using the available ninjs document types
Copy link
Contributor

@bquinn bquinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small suggestion but even without that change it looks fine to me.

},
"assignedTo": {
"description": "The party which is assigned to cover the event and produce the planned item. NOTE G2 object also has coversfrom and coversto attributes, which are also at the higher planning level",
"description": "The human language used by the content. The value should follow IETF BCP47. nar:language",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"used by the planned content" perhaps?

@iyoung iyoung merged commit ad96728 into events-planning Oct 1, 2024
1 check passed
@iyoung iyoung deleted the planned-coverage-tidy branch October 1, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants