-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Benutzerdaten ändern (inkl. Profilbild) #19
Conversation
…lection-fe into feature/initial_card
…to errors during initial creation
image.src = this.fallbackImageUrl; | ||
} | ||
|
||
isCardInvalid(): boolean { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be a variable instead of a getter (is run everytime on change detection)
isCardInvalid = !(
this.userForm.valid &&
!this.image?.nativeElement.src.endsWith(this.fallbackImageUrl)
);```
isCardInvalid(): boolean { | ||
return !( | ||
this.userForm.valid && | ||
!this.image?.nativeElement.src.endsWith(this.fallbackImageUrl) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could add an additional form input, that just holds the image url, then we don't need the direct HTML element ref and can mark it as required.
No description provided.