Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't show appmenu and traditional menu at the same time #536

Closed
lidaobing opened this issue Mar 29, 2024 · 1 comment · Fixed by #537
Closed

Don't show appmenu and traditional menu at the same time #536

lidaobing opened this issue Mar 29, 2024 · 1 comment · Fixed by #537
Assignees
@lidaobing
Labels
2. Linux 2. Snap
Milestone
0.8.5

Comments

@lidaobing
Copy link
Member

image
@lidaobing lidaobing added this to the 0.8.5 milestone Mar 29, 2024
@lidaobing lidaobing self-assigned this Mar 29, 2024
@lidaobing
Copy link
Member Author

how to reproduce:

$ lsb_release -a
No LSB modules are available.
Distributor ID:	Ubuntu
Description:	Ubuntu 22.04.3 LTS
Release:	22.04
Codename:	jammy
$ uname -a
Linux ubuntu-linux-22-04-desktop 5.15.0-91-generic #101-Ubuntu SMP Tue Nov 14 13:29:11 UTC 2023 aarch64 aarch64 aarch64 GNU/Linux
$ snap list iptux
Name   Version               Rev  Tracking     Publisher  Notes
iptux  v0.8.4+git43.94f2a39  600  latest/edge  lidaobing  -

@lidaobing lidaobing linked a pull request Apr 14, 2024 that will close this issue
#536: don't show headerbar and traditional menu at the same time; support headerbar for peer/group dialog #537
Merged
lidaobing added a commit that referenced this issue Apr 14, 2024
@lidaobing
#536: don't show headerbar and traditional menu at the same time; sup…
fef69ff 
…port headerbar for peer/group dialog (#537)

* DialogPeer can use headerbar

* move HeaderBar to uihelper

* DialogGroup can use headerbar

* fix style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lidaobing lidaobing

Labels
2. Linux 2. Snap
Projects
None yet
Milestone
0.8.5
1 participant
@lidaobing