Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependency of libiptux_test #495

Merged
merged 1 commit into from
Nov 18, 2021
Merged

Conversation

r-value
Copy link
Contributor

@r-value r-value commented Nov 17, 2021

iptux/IptuxResource.h in custom target iptux_resource_h is also required in making executable libiptux_test. Absense of this target in source array of libiptux_test (test_sources in meson.build) causes that compiling of cpp sources of libiptux_test may begin before target iptux_resource_h is built, which leads to build failure.

iptux/IptuxResource.h is included in iptux/AboutDialogTest.cpp

`iptux/IptuxResources.h` in target `iptux_resource_h` is also required in making executable `libiptux_test`.
@codecov
Copy link

codecov bot commented Nov 17, 2021

Codecov Report

Merging #495 (b99e9de) into master (b04aab4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #495   +/-   ##
=======================================
  Coverage   44.52%   44.52%           
=======================================
  Files          68       68           
  Lines        7733     7733           
=======================================
  Hits         3443     3443           
  Misses       4290     4290           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b04aab4...b99e9de. Read the comment docs.

@lidaobing lidaobing merged commit 1384997 into iptux-src:master Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants