-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#639: Set the min-size of the input area and info area #646
base: master
Are you sure you want to change the base?
Conversation
Reviewer's Guide by SourceryThis PR sets the minimum size of the input area and info area in the dialog to improve usability. It removes unnecessary includes and sets minimum sizes for these areas using Class diagram showing DialogPeer and DialogBase modificationsclassDiagram
class DialogBase {
+CreateInputArea(): GtkWidget*
-InputAreaMinHeight: int
}
class DialogPeer {
+CreateAllArea(): GtkWidget*
+CreateInfoArea(): GtkWidget*
-InfoAreaMinWidth: int
}
DialogBase <|-- DialogPeer
note for DialogBase "Added InputAreaMinHeight constant (50)"
note for DialogPeer "Added InfoAreaMinWidth constant (100)"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @lidaobing - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #646 +/- ##
=======================================
Coverage 52.47% 52.47%
=======================================
Files 64 64
Lines 8557 8557
=======================================
Hits 4490 4490
Misses 4067 4067 ☔ View full report in Codecov by Sentry. |
Summary by Sourcery
Set the minimum size for the input and info areas in dialogs.
Enhancements: