-
-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] chaines-tv.orange.fr #2514
Conversation
Another possibility is to get the series' name and the episode's title, and concatenate them when available. Thus, the test would need to be edited. Instead of "Tête de liste", per the test's expected result, we would get "Esprits criminels - Tête de liste". (this might lead to an EPG that's clearer to understand). Furthermore, this would also need another case test, in which a movie is being aired (TF1 does this in "Ciné Dimanche", which airs one blockbuster per Sunday evening). |
Test: ```sh npm test -- tvplus.com.tr > test > run-script-os tvplus.com.tr > test:win32 > SET "TZ=Pacific/Nauru" && npx jest --runInBand tvplus.com.tr PASS sites/tvplus.com.tr/tvplus.com.tr.test.js √ can generate valid url (4 ms) √ can parse response (15 ms) √ can handle empty guide Test Suites: 1 passed, 1 total Tests: 3 passed, 3 total Snapshots: 0 total Time: 3.648 s, estimated 4 s Ran all test suites matching /tvplus.com.tr/i. ``` Grab: ```sh npm run grab -- --site=tvplus.com.tr > grab > npx tsx scripts/commands/epg/grab.ts --site=tvplus.com.tr starting... config: output: guide.xml maxConnections: 1 gzip: false site: tvplus.com.tr loading channels... found 10 channel(s) run #1: [1/20] tvplus.com.tr (tr) - 24TV.tr - Dec 15, 2024 (22 programs) [2/20] tvplus.com.tr (tr) - 24TV.tr - Dec 16, 2024 (19 programs) [3/20] tvplus.com.tr (tr) - BabyTV.uk - Dec 16, 2024 (48 programs) [4/20] tvplus.com.tr (tr) - BabyTV.uk - Dec 15, 2024 (48 programs) [5/20] tvplus.com.tr (tr) - ASpor.tr - Dec 16, 2024 (13 programs) [6/20] tvplus.com.tr (tr) - ASpor.tr - Dec 15, 2024 (14 programs) [7/20] tvplus.com.tr (tr) - APara.tr - Dec 16, 2024 (31 programs) [8/20] tvplus.com.tr (tr) - APara.tr - Dec 15, 2024 (25 programs) [9/20] tvplus.com.tr (tr) - AlJazeeraEnglish.qa - Dec 16, 2024 (32 programs) [10/20] tvplus.com.tr (tr) - AlJazeeraEnglish.qa - Dec 15, 2024 (32 programs) [11/20] tvplus.com.tr (tr) - AlJazeera.qa - Dec 16, 2024 (40 programs) [12/20] tvplus.com.tr (tr) - AlJazeera.qa - Dec 15, 2024 (41 programs) [13/20] tvplus.com.tr (tr) - AkitTV.tr - Dec 16, 2024 (15 programs) [14/20] tvplus.com.tr (tr) - AkitTV.tr - Dec 15, 2024 (12 programs) [15/20] tvplus.com.tr (tr) - AHaber.tr - Dec 16, 2024 (27 programs) [16/20] tvplus.com.tr (tr) - AHaber.tr - Dec 15, 2024 (19 programs) [17/20] tvplus.com.tr (tr) - A2TV.tr - Dec 16, 2024 (11 programs) [18/20] tvplus.com.tr (tr) - A2TV.tr - Dec 15, 2024 (11 programs) [19/20] tvplus.com.tr (tr) - 360.tr - Dec 16, 2024 (18 programs) [20/20] tvplus.com.tr (tr) - 360.tr - Dec 15, 2024 (18 programs) saving to "guide.xml"... done in 00h 02m 17s ``` Signed-off-by: Toha <tohenk@yahoo.com>
Test: ```sh npm test -- tvplus.com.tr > test > run-script-os tvplus.com.tr > test:win32 > SET "TZ=Pacific/Nauru" && npx jest --runInBand tvplus.com.tr PASS sites/tvplus.com.tr/tvplus.com.tr.test.js √ can generate valid url (4 ms) √ can parse response (15 ms) √ can handle empty guide Test Suites: 1 passed, 1 total Tests: 3 passed, 3 total Snapshots: 0 total Time: 3.648 s, estimated 4 s Ran all test suites matching /tvplus.com.tr/i. ``` Grab: ```sh npm run grab -- --site=tvplus.com.tr > grab > npx tsx scripts/commands/epg/grab.ts --site=tvplus.com.tr starting... config: output: guide.xml maxConnections: 1 gzip: false site: tvplus.com.tr loading channels... found 10 channel(s) run #1: [1/20] tvplus.com.tr (tr) - 24TV.tr - Dec 15, 2024 (22 programs) [2/20] tvplus.com.tr (tr) - 24TV.tr - Dec 16, 2024 (19 programs) [3/20] tvplus.com.tr (tr) - BabyTV.uk - Dec 16, 2024 (48 programs) [4/20] tvplus.com.tr (tr) - BabyTV.uk - Dec 15, 2024 (48 programs) [5/20] tvplus.com.tr (tr) - ASpor.tr - Dec 16, 2024 (13 programs) [6/20] tvplus.com.tr (tr) - ASpor.tr - Dec 15, 2024 (14 programs) [7/20] tvplus.com.tr (tr) - APara.tr - Dec 16, 2024 (31 programs) [8/20] tvplus.com.tr (tr) - APara.tr - Dec 15, 2024 (25 programs) [9/20] tvplus.com.tr (tr) - AlJazeeraEnglish.qa - Dec 16, 2024 (32 programs) [10/20] tvplus.com.tr (tr) - AlJazeeraEnglish.qa - Dec 15, 2024 (32 programs) [11/20] tvplus.com.tr (tr) - AlJazeera.qa - Dec 16, 2024 (40 programs) [12/20] tvplus.com.tr (tr) - AlJazeera.qa - Dec 15, 2024 (41 programs) [13/20] tvplus.com.tr (tr) - AkitTV.tr - Dec 16, 2024 (15 programs) [14/20] tvplus.com.tr (tr) - AkitTV.tr - Dec 15, 2024 (12 programs) [15/20] tvplus.com.tr (tr) - AHaber.tr - Dec 16, 2024 (27 programs) [16/20] tvplus.com.tr (tr) - AHaber.tr - Dec 15, 2024 (19 programs) [17/20] tvplus.com.tr (tr) - A2TV.tr - Dec 16, 2024 (11 programs) [18/20] tvplus.com.tr (tr) - A2TV.tr - Dec 15, 2024 (11 programs) [19/20] tvplus.com.tr (tr) - 360.tr - Dec 16, 2024 (18 programs) [20/20] tvplus.com.tr (tr) - 360.tr - Dec 15, 2024 (18 programs) saving to "guide.xml"... done in 00h 02m 17s ``` Signed-off-by: Toha <tohenk@yahoo.com>
Resolves #2354 Details: npm/cli#3136
Test: ```sh npm test -- tvplus.com.tr > test > run-script-os tvplus.com.tr > test:win32 > SET "TZ=Pacific/Nauru" && npx jest --runInBand tvplus.com.tr PASS sites/tvplus.com.tr/tvplus.com.tr.test.js √ can generate valid url (4 ms) √ can parse response (15 ms) √ can handle empty guide Test Suites: 1 passed, 1 total Tests: 3 passed, 3 total Snapshots: 0 total Time: 3.648 s, estimated 4 s Ran all test suites matching /tvplus.com.tr/i. ``` Grab: ```sh npm run grab -- --site=tvplus.com.tr > grab > npx tsx scripts/commands/epg/grab.ts --site=tvplus.com.tr starting... config: output: guide.xml maxConnections: 1 gzip: false site: tvplus.com.tr loading channels... found 10 channel(s) run #1: [1/20] tvplus.com.tr (tr) - 24TV.tr - Dec 15, 2024 (22 programs) [2/20] tvplus.com.tr (tr) - 24TV.tr - Dec 16, 2024 (19 programs) [3/20] tvplus.com.tr (tr) - BabyTV.uk - Dec 16, 2024 (48 programs) [4/20] tvplus.com.tr (tr) - BabyTV.uk - Dec 15, 2024 (48 programs) [5/20] tvplus.com.tr (tr) - ASpor.tr - Dec 16, 2024 (13 programs) [6/20] tvplus.com.tr (tr) - ASpor.tr - Dec 15, 2024 (14 programs) [7/20] tvplus.com.tr (tr) - APara.tr - Dec 16, 2024 (31 programs) [8/20] tvplus.com.tr (tr) - APara.tr - Dec 15, 2024 (25 programs) [9/20] tvplus.com.tr (tr) - AlJazeeraEnglish.qa - Dec 16, 2024 (32 programs) [10/20] tvplus.com.tr (tr) - AlJazeeraEnglish.qa - Dec 15, 2024 (32 programs) [11/20] tvplus.com.tr (tr) - AlJazeera.qa - Dec 16, 2024 (40 programs) [12/20] tvplus.com.tr (tr) - AlJazeera.qa - Dec 15, 2024 (41 programs) [13/20] tvplus.com.tr (tr) - AkitTV.tr - Dec 16, 2024 (15 programs) [14/20] tvplus.com.tr (tr) - AkitTV.tr - Dec 15, 2024 (12 programs) [15/20] tvplus.com.tr (tr) - AHaber.tr - Dec 16, 2024 (27 programs) [16/20] tvplus.com.tr (tr) - AHaber.tr - Dec 15, 2024 (19 programs) [17/20] tvplus.com.tr (tr) - A2TV.tr - Dec 16, 2024 (11 programs) [18/20] tvplus.com.tr (tr) - A2TV.tr - Dec 15, 2024 (11 programs) [19/20] tvplus.com.tr (tr) - 360.tr - Dec 16, 2024 (18 programs) [20/20] tvplus.com.tr (tr) - 360.tr - Dec 15, 2024 (18 programs) saving to "guide.xml"... done in 00h 02m 17s ``` Signed-off-by: Toha <tohenk@yahoo.com>
Co-authored-by: Aleksandr Statciuk <7253922+freearhey@users.noreply.github.com>
I've allowed myself to add some additional content that could be useful in the EPG. Feel free to check now. |
|
The test being in error is the test i've fixed... rather odd. |
I believe some of the code isn't compatible with Windows OS. $ npm install
> postinstall
> npm run api:load
> api:load
> npx tsx scripts/commands/api/load.ts
channels.json [====================================] 100.00% | ETA: 0s | 1.8 MB | 5.3 KB/s
countries.json [====================================] 100.00% | ETA: 0s | 4.3 KB | N/A
regions.json [====================================] 100.00% | ETA: 0s | 2.2 KB | N/A
subdivisions.json [====================================] 100.00% | ETA: 0s | 36.6 KB | N/A
added 795 packages, and audited 796 packages in 18s
127 packages are looking for funding
run `npm fund` for details
1 critical severity vulnerability
Some issues need review, and may require choosing
a different dependency.
Run `npm audit` for details.
$ npm test --- chaines-tv.orange.fr
> test
> run-script-os chaines-tv.orange.fr
> test:default
> TZ=Pacific/Nauru npx jest --runInBand chaines-tv.orange.fr
PASS sites/chaines-tv.orange.fr/chaines-tv.orange.fr.test.js (5.116 s)
✓ can generate valid url (2 ms)
✓ can parse response (2 ms)
✓ can handle empty guide (1 ms)
Test Suites: 1 passed, 1 total
Tests: 3 passed, 3 total
Snapshots: 0 total
Time: 5.18 s
Ran all test suites matching /chaines-tv.orange.fr/i. |
@PopeyeTheSai10r In this case, I don't think that's the problem. Otherwise you would have seen a similar error when testing other sites. Perhaps the bug occurred when downloading the latest version of PR to your computer. Try to compare the line 19 and 20 from here: https://github.com/iptv-org/epg/pull/2514/files with what you have locally. They should be identical. |
I completed removed the Github app and local copy of repo, then re-download everything to start fresh. The test passed when I switched to the branch and ran |
Change priority in item title, leading in the test being fixed.
Also add season & episode data when available.
Closes #2395