Add ServiceCollectionExtensions and ServiceProviderMiddlewareResolver #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariusz96
changed the title
mariusz96
changed the title
mariusz96
changed the title
mariusz96
changed the title
mariusz96
changed the title
…MiddlewareResolver
mariusz96
commented
Aug 20, 2024
|
|
||
| var openGenericTypes = new List<Type>() | ||
| { | ||
| typeof(IMiddleware<>), |
There was a problem hiding this comment.
ICancelalbleAsyncMiddleware<> and ICancelalbleAsyncMiddleware<,> should be added here when the other PR is merged.
There was a problem hiding this comment.
Also IFinally<,>, IAsyncFinally<,> and ICancellableAsyncFinally<,>.
mariusz96
changed the title
mariusz96
force-pushed
the
di
branch
5 times, most recently
from
c4b2c5b
to
62dbd4b
Compare
mariusz96
force-pushed
the
di
branch
3 times, most recently
from
76020a0
to
2a3982c
Compare
mariusz96
force-pushed
the
di
branch
3 times, most recently
from
30eaa54
to
f75ed23
Compare
ipvalverde
approved these changes
Oct 13, 2024
| /// Set this to <see langword="true"/> if the middleware is IDisposable or | ||
| /// IAsyncDisposable (requires .NET Standard 2.1 or greater) | ||
| /// and was not created by a dependency injection container. | ||
| /// and is not disposed by a dependency injection container. | ||
| /// </summary> | ||
| public bool IsDisposable { get; set; } |
There was a problem hiding this comment.
Before we get to the next breaking change, this property should be renamed to add more clarity. Maybe something like DisposeAfterUsage or just Dispose.
There was a problem hiding this comment.
Dispose sounds good.
I will also remove the 'if the middleware is IDisposable or IAsyncDisposable' from MiddlewareResolverResult and IMiddlewareResolver. It is enough to check this in BaseMiddlewareFlow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR for #24.