Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add enable mDNS and Rendezvous config settings #376

Closed
bgins opened this issue Oct 11, 2023 · 0 comments · Fixed by #377
Closed

Add enable mDNS and Rendezvous config settings #376

bgins opened this issue Oct 11, 2023 · 0 comments · Fixed by #377
Assignees
@bgins
Labels
enhancement New feature or request networking Features, functionality involving networking

Comments

@bgins
Copy link
Contributor

bgins commented Oct 11, 2023

Summary

Problem

We run libp2p mDNS and Rendezvous by default as a best effort mechanism to connect peers, but there are some circumstances where we don't want them all running.

Impact

Testing can be challenging when we want to check that one behavior or another is responsible for discovery or establishing a peer connection.

Some binary users may want to shut off these behaviors. For example, mDNS may not be useful to a Homestar node not running on a LAN.

Solution

Add configs to turn mDNS and Rendezvous behaviors on or off.
@bgins bgins added enhancement New feature or request networking Features, functionality involving networking labels Oct 11, 2023
@bgins bgins self-assigned this Oct 11, 2023
@bgins bgins mentioned this issue Oct 11, 2023
Merged
4 tasks
bgins added a commit that referenced this issue Oct 12, 2023
@bgins
feat: Add mDNS and Rendezvous configs (#377)
ea11c27 
# Description

This PR implements the following features:

- [x] Add `enable_mdns` config
- [x] Add `enable_rendezvous` config

These configs determine whether we toggle mDNS and Rendezvous on or off.
In addition, we check the toggle states in event handlers where we might
use mDNS or Rendezvous.

## Link to issue

Closes #376 

## Type of change

- [x] New feature (non-breaking change that adds functionality)
- [x] Refactor (non-breaking change that updates existing functionality)

## Test plan (required)

All existing tests should pass. In particular, we are interested in the
multi-node tests that rely on known peers and mDNS.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bgins bgins

Labels
enhancement New feature or request networking Features, functionality involving networking
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add mDNS and Rendezvous configs ipvm-wg/homestar
1 participant
@bgins