Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add libp2p metrics #330

Closed
wants to merge 1 commit into from
Closed

feat: Add libp2p metrics #330

wants to merge 1 commit into from

Conversation

bgins
Copy link
Contributor

@bgins bgins commented Sep 26, 2023

Description

This pull request adds the following features:

  • Add libp2p swarm metrics
  • Add metrics_record macro

Very much WIP. Depends on some initial work in #131.

Link to issue

Implements #184.

Type of change

  • New feature (non-breaking change that adds functionality)
  • Refactor (non-breaking change that updates existing functionality)

Test plan (required)

We will add integration tests to check the metrics.

@bgins bgins added the observability Anything related to metrics, tracing, etc label Sep 26, 2023
@bgins bgins self-assigned this Sep 26, 2023
@mxinden
Copy link

mxinden commented Oct 18, 2023

Unsolicited advice, this might be helpful: https://github.com/libp2p/rust-libp2p/tree/master/misc/metrics

@bgins
Copy link
Contributor Author

bgins commented Oct 18, 2023

Unsolicited advice, this might be helpful: https://github.com/libp2p/rust-libp2p/tree/master/misc/metrics

That looks great! Thank you for mentioning it. 🙏

@zeeshanlakhani
Copy link
Contributor

zeeshanlakhani commented Oct 18, 2023

Unsolicited advice, this might be helpful: https://github.com/libp2p/rust-libp2p/tree/master/misc/metrics

Yep. Well aware. We're not directly using the prom client lib, but this will be heavily influenced by that work y'all did :).

@bgins
Copy link
Contributor Author

bgins commented Feb 13, 2024

Closed because this branch is stale and not a priority at the moment. Leaving the issue open to pick up later.

@bgins bgins closed this Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
observability Anything related to metrics, tracing, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants