Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move away from deadlines dealing w/ the runner and wasi-preview 2 wasmtime #560

Merged
merged 2 commits into from
Feb 7, 2024

Conversation

zeeshanlakhani
Copy link
Contributor

Includes:

  • no more recv_deadlines, use sink timeout/other time mechanisms to the servers
  • remove faked runner/webserver timeout test
  • hakari configuration updates to remove guest crate/paths
  • cid changes everywhere
  • wasm-tools update with flake

@zeeshanlakhani zeeshanlakhani requested a review from a team as a code owner February 7, 2024 16:46
…wasi-preview 2 wasmtime

Includes:

- no more recv_deadlines, use sink timeout/other time mechanisms to the servers
- remove faked runner/webserver timeout test
- hakari configuration updates to remove guest crate/paths
- cid changes everywhere
- wasm-tools update with flake
Copy link

codecov bot commented Feb 7, 2024

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (e0bb469) 76.90% compared to head (04f4a35) 78.62%.
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #560      +/-   ##
==========================================
+ Coverage   76.90%   78.62%   +1.71%     
==========================================
  Files          83       83              
  Lines        9805     9262     -543     
==========================================
- Hits         7541     7282     -259     
+ Misses       2264     1980     -284     
Files Coverage Δ
homestar-invocation/src/task.rs 91.19% <100.00%> (ø)
homestar-invocation/src/task/instruction.rs 68.48% <100.00%> (ø)
homestar-runtime/src/event_handler.rs 100.00% <ø> (ø)
homestar-runtime/src/network/webserver.rs 96.78% <100.00%> (-0.24%) ⬇️
homestar-runtime/src/network/webserver/rpc.rs 75.73% <100.00%> (+4.60%) ⬆️
homestar-runtime/src/runner.rs 93.70% <ø> (+6.12%) ⬆️
homestar-runtime/src/settings.rs 98.17% <100.00%> (ø)
homestar-runtime/src/tasks/fetch.rs 100.00% <ø> (ø)
homestar-wasm/src/wasmtime/world.rs 85.00% <50.00%> (ø)
homestar-runtime/src/runner/response.rs 69.67% <0.00%> (-2.33%) ⬇️
... and 1 more

... and 13 files with indirect coverage changes

Copy link
Contributor

@bgins bgins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Let's bring it in.

@zeeshanlakhani zeeshanlakhani merged commit 80003b5 into main Feb 7, 2024
33 checks passed
@zeeshanlakhani zeeshanlakhani deleted the zl/new-wasmtime+no-deadline branch February 7, 2024 17:33
@release-plz-ipvm-wg release-plz-ipvm-wg bot mentioned this pull request Feb 7, 2024
zeeshanlakhani pushed a commit that referenced this pull request Feb 21, 2024
## 🤖 New release
* `homestar-runtime`: 0.1.1 -> 0.2.0 (⚠️ API breaking changes)
* `homestar-invocation`: 0.1.1 -> 0.2.0 (✓ API compatible changes)
* `homestar-wasm`: 0.1.1 -> 0.2.0 (✓ API compatible changes)
* `homestar-workflow`: 0.1.1 -> 0.2.0 (✓ API compatible changes)

### ⚠️ `homestar-runtime` breaking changes

```
--- failure enum_variant_added: enum variant added on exhaustive enum ---

Description:
A publicly-visible enum without #[non_exhaustive] has a new variant.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#enum-variant-new
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.28.0/src/lints/enum_variant_added.ron

Failed in:
  variant Command:Node in /tmp/.tmp7PLiiL/homestar/homestar-runtime/src/cli.rs:149
  variant Command:Info in /tmp/.tmp7PLiiL/homestar/homestar-runtime/src/cli.rs:155
```

<details><summary><i><b>Changelog</b></i></summary><p>

## `homestar-runtime`
<blockquote>

##
[0.2.0](homestar-runtime-v0.1.1...homestar-runtime-v0.2.0)
- 2024-02-20

### Added
- Add OpenRPC API docs and associated JSON Schemas
([#534](#534))
- redial `node_addresses` at an interval on connection close
([#529](#529))

### Fixed
- add handling of dns multiaddrs + bootstrapping + CLI / Conn changes
([#547](#547))

### Other
- deps + flake cleanup
([#581](#581))
- Allow dead code default timeout
([#577](#577))
- Update homestar-functions to use cargo component
([#576](#576))
- fix transport order for wss possibility
([#563](#563))
- small comment, sorry
([#561](#561))
- move away from deadlines dealing w/ the runner and wasi-preview 2
wasmtime ([#560](#560))
- docker updates with info command and rpc host update
([#558](#558))
- just test conn ([#544](#544))
- handle this evil workflow_info test
([#543](#543))
- remove unnecessary deps and add tooling for those checks
([#541](#541))
- [chore(cargo)](deps): bump puffin from 0.18.1 to 0.19.0
([#537](#537))
- updates/flaky kills on ci
([#540](#540))
- release docs and cp readmes
([#530](#530))
- port selection and test config generation macro
([#528](#528))
- [chore(cargo)](deps): bump serde_with from 3.4.0 to 3.5.0
([#524](#524))
- [chore(cargo)](deps): bump moka from 0.12.3 to 0.12.4
([#525](#525))
</blockquote>

## `homestar-invocation`
<blockquote>

##
[0.2.0](homestar-invocation-v0.1.1...homestar-invocation-v0.2.0)
- 2024-02-20

### Added
- Add OpenRPC API docs and associated JSON Schemas
([#534](#534))

### Other
- deps + flake cleanup
([#581](#581))
- Update homestar-functions to use cargo component
([#576](#576))
- move away from deadlines dealing w/ the runner and wasi-preview 2
wasmtime ([#560](#560))
- remove unnecessary deps and add tooling for those checks
([#541](#541))
- release docs and cp readmes
([#530](#530))
</blockquote>

## `homestar-wasm`
<blockquote>

##
[0.2.0](homestar-wasm-v0.1.1...homestar-wasm-v0.2.0)
- 2024-02-20

### Other
- deps + flake cleanup
([#581](#581))
- Update homestar-functions to use cargo component
([#576](#576))
- move away from deadlines dealing w/ the runner and wasi-preview 2
wasmtime ([#560](#560))
- remove unnecessary deps and add tooling for those checks
([#541](#541))
- release docs and cp readmes
([#530](#530))
</blockquote>

## `homestar-workflow`
<blockquote>

##
[0.2.0](homestar-workflow-v0.1.1...homestar-workflow-v0.2.0)
- 2024-02-20

### Added
- Add OpenRPC API docs and associated JSON Schemas
([#534](#534))

### Other
- deps + flake cleanup
([#581](#581))
- remove unnecessary deps and add tooling for those checks
([#541](#541))
- release docs and cp readmes
([#530](#530))
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/MarcoIeni/release-plz/).

Signed-off-by: release-plz-ipvm-wg[bot] <144082651+release-plz-ipvm-wg[bot]@users.noreply.github.com>
Co-authored-by: release-plz-ipvm-wg[bot] <144082651+release-plz-ipvm-wg[bot]@users.noreply.github.com>
@release-plz-ipvm-wg release-plz-ipvm-wg bot mentioned this pull request Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants