Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collapsible Headings copy/paste issue #1082

Closed
kjslag opened this issue Sep 7, 2017 · 2 comments · Fixed by #1109
Closed

Collapsible Headings copy/paste issue #1082

kjslag opened this issue Sep 7, 2017 · 2 comments · Fixed by #1109

Comments

@kjslag
Copy link

kjslag commented Sep 7, 2017

With the Collapsible Headings extension enabled, copy-pasting a collapsed heading does not work.

Steps to reproduce:

  1. make a heading and collapse it
  2. copy the collapsed heading
  3. paste it below any collapsed heading
    The pasted heading (and any collapsed contents) is not displayed! However, if you save and then reload the notebook, the heading is displayed correctly.
@jcb91
Copy link
Member

jcb91 commented Sep 7, 2017

Hmm. I guess this might be something to do with the new heading cell not being rendered when it's pasted. I've managed to reproduce this on mobile, but will need to debug a little better when I get back to a desktop. Thanks for reporting!

jcb91 added a commit to jcb91/jupyter_contrib_nbextensions that referenced this issue Sep 25, 2017
@jcb91
Copy link
Member

jcb91 commented Sep 25, 2017

yeah, so this is because when the cell gets added, it's hidden by the (existing) heading, then when it gets rendered, the update only considers cells below the rendering one (since it assumes the cell being rendered is visible). The simplest fix is to simply always consider all cells when updating on a render event.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants