improved running-server checks for install #1045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use the notebook-provided list_running_servers function to check for running notebook servers, rather than using our previous psutil effort.
allows simple installation in multiple-environment or multi-user configurations
|
👍 Good idea! Can you add a description of the new flag to the docs ? |
|
I've added a note of explanation to the main readme & the corresponding docs page, hope it makes sense 😄 |
|
Great. Looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1043 by obviating the requirement for psutils, relying instead on the (presumably more reliable) method of using notebook-provided functions to check for running servers. Also adds a flat to allow install/uninstall actions without checking for running servers.