Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update yaml files for 5.x compatible nbextensions #1055

Merged
merged 3 commits into from
Aug 23, 2017

Conversation

jfbercher
Copy link
Member

I have gone though the nbextensions this evening and marked those which seems working for me. I haven't tested everything but at least the basic functionality is present in these extensions. Most of the nbextensions work.
I have a doubt concerning split cells notebook, scrolldown and haven't tested skill syntax.

@jcb91
Copy link
Member

jcb91 commented Aug 20, 2017

Thanks, good work @jfbercher.

Skill syntax is pretty much just a codemirror mode, which means it relies little on notebook & should be fine on 5.x. I think we can update it & wait for bug reports 😉. What were your doubts about split cell & scrolldown?

@jfbercher
Copy link
Member Author

if I remember well, split cell was splitting horizontally the cell with code on the left and output on the right. This is no more the case: code + output are on the 50% left. You are the author @jcb91 ?
For scolldown, it seems that it doesn't scroll at all @kukanya ?

@jcb91
Copy link
Member

jcb91 commented Aug 21, 2017

This is no more the case: code + output are on the 50% left. You are the author @jcb91 ?

No, I'm not the original author, and haven't used it, so I'm not sure, but from memory I think the idea is that a split cell should be 50% left, so that the next cell can be 50% right, and the two end up side by side. Maybe I've got that confused though...

@jfbercher
Copy link
Member Author

No, you are right. It is what it does. So it works.
I think that I have seen the other extension (split input/output) elsewhere else. I will mark skill and splitcell as 5.x compatible.

@jcb91 jcb91 merged commit 3a497b0 into ipython-contrib:master Aug 23, 2017
@jcb91
Copy link
Member

jcb91 commented Aug 23, 2017

thanks for this @jfbercher

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants