Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cell filter extension #1240

Merged
merged 4 commits into from
Feb 23, 2018
Merged

Cell filter extension #1240

merged 4 commits into from
Feb 23, 2018

Conversation

benelot
Copy link
Contributor

@benelot benelot commented Feb 16, 2018

I finally finished my second extension. Filter by tags in the notebook section. Thanks for the inputs in #1214, the disabling of the keyboard shortcuts basically made it work for the first time.

@benelot
Copy link
Contributor Author

benelot commented Feb 16, 2018

I just realized I forgot to hide outputs! Well. I am going to add that soon.

@benelot
Copy link
Contributor Author

benelot commented Feb 16, 2018

I will test some more if I find problems. Then it should be good to go.

@jcb91
Copy link
Member

jcb91 commented Feb 17, 2018

This looks good to me, although it won't play well with collapsible headings as it is at the moment. That's ok though, a separate PR some other time can get them working nicely together. Could you add a note to the github master section of the changelog about the new addition? Thanks :)

@benelot
Copy link
Contributor Author

benelot commented Feb 17, 2018

Oh right, I forgot the changelog again. Will do it soon.

I realized the issue with collapsible headings and some other extensions that show additional features, but I did not know how to handle them and be safe if they are not enabled. Let us check that in a separate PR.

@benelot
Copy link
Contributor Author

benelot commented Feb 22, 2018

Done! Ready to pull.

@juhasch
Copy link
Member

juhasch commented Feb 23, 2018

Looks good to me. The appveyor error looks unrelated.

@juhasch juhasch merged commit 96ab1d4 into ipython-contrib:master Feb 23, 2018
@syagev
Copy link

syagev commented Dec 3, 2020

@benelot this extension seems very useful to me, but where is the mentioned "search bar"? I can't find it 😳...

image

@benelot
Copy link
Contributor Author

benelot commented Dec 3, 2020

@syagev Happy to hear my extension could be useful to you. The search bar should be added to the maintoolbae container at the top.

var form = $('<form/>')                                                                                     // insert a form into the main toolbar container
            .css('padding', '0 7px 4px')
            .appendTo('#maintoolbar-container');

Maybe they renamed that and the extension broke? Not sure. The searchbox should be all to the right in the same toolbar as the Run button and the Code Dropdown. If you are familiar with the developer tools of your browser, you could quickly check if the toolbar still has the same ID.

@syagev
Copy link

syagev commented Dec 6, 2020

Thanks for the reply @benelot, I took a look at the console as suggested and opened a ticket - #1542

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants