-
Notifications
You must be signed in to change notification settings - Fork 812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cell filter extension #1240
Cell filter extension #1240
Conversation
I just realized I forgot to hide outputs! Well. I am going to add that soon. |
I will test some more if I find problems. Then it should be good to go. |
This looks good to me, although it won't play well with collapsible headings as it is at the moment. That's ok though, a separate PR some other time can get them working nicely together. Could you add a note to the github master section of the changelog about the new addition? Thanks :) |
Oh right, I forgot the changelog again. Will do it soon. I realized the issue with collapsible headings and some other extensions that show additional features, but I did not know how to handle them and be safe if they are not enabled. Let us check that in a separate PR. |
Done! Ready to pull. |
Looks good to me. The appveyor error looks unrelated. |
@benelot this extension seems very useful to me, but where is the mentioned "search bar"? I can't find it 😳... |
@syagev Happy to hear my extension could be useful to you. The search bar should be added to the maintoolbae container at the top.
Maybe they renamed that and the extension broke? Not sure. The searchbox should be all to the right in the same toolbar as the Run button and the Code Dropdown. If you are familiar with the developer tools of your browser, you could quickly check if the toolbar still has the same ID. |
I finally finished my second extension. Filter by tags in the notebook section. Thanks for the inputs in #1214, the disabling of the keyboard shortcuts basically made it work for the first time.