-
Notifications
You must be signed in to change notification settings - Fork 806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add short execution threshold for ExecutionTime plugin #1336
Conversation
Hide short executions, but still render them if they were reenabled via menus.
Set min value to 0, without upper bank and default of 0
src/jupyter_contrib_nbextensions/nbextensions/execute_time/ExecuteTime.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but the scope of the variable exec_time is a bit gnarly like this
Fix an issue where exec_time variable could be undefined.
Hi, I think this feature is good, and it would be great if it could be integrated. The Appveyor build seems to be failing for the python 2.7 environment. Here is the command and its output that seems to make the build process fail :
From what I understand, there is a problem when installing the dependencies. It tries to install Ipython 7.0+ which does not support python 2.7. But this problem is well above my skills for me to try to solve it. I hope this message will relaunch interest in this pull request. |
Synced with master branch which triggered new build. No more Python2.7 build issues. |
Friendly ping |
Thank you and sorry for the long delay. |
As per issue 1335, I created code change that will hide short execution times.