toc2: update for html export + notebook menus set to the left #803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
move title/menus/icons on left, following suggestion in ipython-contrib#650
|
Moving title/menus/icons to the left:
Finally, I have put this as a user configurable parameter (with a default to true, that is "move") |
sounds good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since previous PR, the highlighting colors for the sections in toc with selected/edited/running cells are user configurable and are set directly by javascript (config is read from system). However, when exporting to html, the style is not defined. This PR simply adds a default config (for hover highlighting) which is used by documents exported to html and overwritten in the live notebook.
In Centered title/menus when using toc2-sidebar view looks odd #650, @Kevin-McIsaac suggested to move title/menus/icons on left.
Indeed, since the introduction of the toc sidebar, the toc2 extension resizes the main container to fit the whole window and add the sidebar. Centered menus then sometimes look odd. I agree with the suggestion. The PR adds a small styling in toc css to move the menu to the left. However, I am not sure if it should be done here, or left to the users, or put as a configuration option. Thoughts?