Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[limit_output] updates including allowing per-cell override of limit #813

Merged
merged 8 commits into from
Dec 3, 2016

Conversation

jcb91
Copy link
Member

@jcb91 jcb91 commented Dec 2, 2016

  • allow cell-specific override of output length via cell.metadata.limit_output
  • make output-limited notes persist through notebook save & reload by adding them as actual output, rather than just calling OutputArea.append_display_data
  • limit outputs even over several distinct output events. Previously, stdout outputs separated in time would each be limited separately, rather than taking all of the outputs as a whole.

@jcb91
Copy link
Member Author

jcb91 commented Dec 2, 2016

(fixes #811)

@juhasch
Copy link
Member

juhasch commented Dec 2, 2016

Looks good to me.

@jcb91 jcb91 changed the title [limit_output] udates including allowing per-cell override of limit [limit_output] updates including allowing per-cell override of limit Dec 2, 2016
@jcb91
Copy link
Member Author

jcb91 commented Dec 2, 2016

there's a long OSX backlog on Travis, so CI checks may take a long time to go through, but since these changes won't be covered by the tests anyway, I don't think we necessarily need to wait for them if it seems to work for people in their own testning

@juhasch
Copy link
Member

juhasch commented Dec 2, 2016

I think there really is no need to wait for the OSX tests, too.

@jcb91 jcb91 merged commit 3c290a2 into ipython-contrib:master Dec 3, 2016
@jcb91 jcb91 deleted the limit_output branch December 5, 2016 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants