New notebook extension: code snippets #826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nice :) reminds me of https://github.com/moble/jupyter_boilerplate, which I've always thought we should add, but never got round to asking @moble about it |
jcb91
reviewed
Jan 2, 2017
| function load_extension() { | ||
| config.load(); // trigger loading config parameters | ||
|
|
||
| $.getJSON("/nbextensions/snippets/snippets.json", function(data) { |
There was a problem hiding this comment.
Sorry, should have picked this up before, but this path will fail on anyn server not using the default base_url of /, for example on jupyterhub. A better solution would be to use a relative path ./snippets.json
There was a problem hiding this comment.
Also, the $.getJSON callback relies on the config.loaded already having added the select, so it might be better to chain them directly. I should have mentioned these before merging, really, sorry!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new notebook extension for inserting code snippet cells into the current notebook. When enabled, the extension inserts a drop-down menu into the toolbar with a list of named code snippets specified by the user in
nbextensions/snippets/snippets.json. The extension ships with an example snippet.This is based off of an old extension of mine.