Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix init cell extension bug on trust warning #834

Merged
merged 2 commits into from
Jan 5, 2017

Conversation

lspvic
Copy link
Contributor

@lspvic lspvic commented Jan 5, 2017

When load a Jupyter notebook, the trust warning model dialog always displayed and init cell are not executed although I am very sure that the notebook is trusted.
I debugged the script, found that the notebook's trust property was not initiated with null when checking, as below:

20170105170321

this is because the init_cell extension is loaded before notebook is fully loaded. I found when the notebook is big or the network is slow, the bug occurs, so I do a check on whether the notebook is loaded, if not, binding an notebook_loaded event to execute the init run.

@lspvic lspvic changed the title fix bug on trust warning fix init cell extension bug on trust warning Jan 5, 2017
@jcb91
Copy link
Member

jcb91 commented Jan 5, 2017

Good spot, neat fix, thanks @lspvic!

@jcb91 jcb91 merged commit 6284e8e into ipython-contrib:master Jan 5, 2017
@lspvic lspvic deleted the init_cell_fix branch January 5, 2017 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants