fix init cell extension bug on trust warning #834
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When load a Jupyter notebook, the trust warning model dialog always displayed and init cell are not executed although I am very sure that the notebook is trusted.
I debugged the script, found that the notebook's
trust
property was not initiated withnull
when checking, as below:this is because the init_cell extension is loaded before notebook is fully loaded. I found when the notebook is big or the network is slow, the bug occurs, so I do a check on whether the notebook is loaded, if not, binding an
notebook_loaded
event to execute the init run.