[toc2] update for cells width ans sidebar height #994
Conversation
| @@ -176,15 +177,15 @@ var make_link = function(h, num_lbl) { | |||
| $('#notebook-container').css('margin-left', 30); | |||
| $('#notebook-container').css('width', $('#notebook').width() - 30); | |||
| } else { // original width | |||
| $("#notebook-container").css({'width':"82%", 'margin-left':'auto'}) | |||
| $("#notebook-container").css({'width':st.nbcontainer_width, 'margin-left':'auto'}) | |||
There was a problem hiding this comment.
I think this should probably set an empty string, to not set anything, otherwise it'll break when the window is resized.
There was a problem hiding this comment.
Yes, you are right. thanks
| //cfg.widenNotebook = false; | ||
| function setNotebookWidth(cfg, st, sideBarIsToggling) { | ||
| //cfg.widenNotebook = true; | ||
| var sideBarIsToggling = typeof sideBarIsToggling !== 'undefined' ? sideBarIsToggling : false; |
There was a problem hiding this comment.
this sideBarIsToggling variable doesn't actually seem to get used anywhere - what is it intended for?
There was a problem hiding this comment.
Nothing. Indeed it is a dead code from a previous attempt. I remove it.
| @@ -176,19 +177,28 @@ var make_link = function(h, num_lbl) { | |||
| $('#notebook-container').css('margin-left', 30); | |||
| $('#notebook-container').css('width', $('#notebook').width() - 30); | |||
| } else { // original width | |||
| $("#notebook-container").css({'width':"82%", 'margin-left':'auto'}) | |||
| $("#notebook-container").css({'width':'', 'margin-left':'auto'}) | |||
There was a problem hiding this comment.
the margin-left should probably also be reset here (admittedly, it does end up as auto with the default css, but it's neater to just remove the override, in case anyone is trying to customize things)
jfbercher
changed the title
|
Thanks to @jcb91 for reviewing and directions for improvements. |
This address issue #993. In case nothing is selected (no widenNotebook and no Sidebar), then don't modify or restore cells width to the original width.
In passing I see that I had a pending modification that should improve the transition effect when toggling the sidebar visibility.Also recompute sidebar height on window resize event.