-
-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Debugger always disabled with ipykernel 6.4.0? #770
Comments
The kernelspec is not dynamic; it is served from a JSON file shipped within the wheel. So the solution implemented in #767 does not work. I would recommend reverting #767 for now as removing |
There is a field in the Is there a reason for using the kernelspec instead of the |
Yes. The debugger extension used to use the field from the |
Thanks @jtpio! So a possible solution to this issue could be:
OR the kernelspec always sets the field in the kernelspec to True, and it's up to package maintainers who want to remove dependency on debugpy to overwrite this field when they generate the package. |
#773 should fix the wheel metadata I do think getting this (and all kernel capability detection) from kernel_info_reply is a better practice in general, since it's more reliably accurate than something set at build-time. To solve the 'kernel busy on reload' issue, maybe the server should cache a first-time kernel info reply and serve that somehow without re-pinging kernels? |
Using the latest
6.4.0
version ofipykernel
, it looks like the debugger is always disabled.This was first noticed on Binder using this gist: https://gist.github.com/jtpio/6ce26381703355e0ef1da4af742b7f72
But can be reproduced locally:
The spec seems to be installed with
debugger: false
on disk:And the kernelspecs return
debugger: false
foripykernel
at startup:Dependencies:
The text was updated successfully, but these errors were encountered: