Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dumpCell returns paths with mixed slashes on Windows #995

Closed
roblourens opened this issue Sep 21, 2022 · 1 comment
Closed

dumpCell returns paths with mixed slashes on Windows #995

roblourens opened this issue Sep 21, 2022 · 1 comment

Comments

@roblourens
Copy link

Debugging with Jupyter on Windows (via vscode-jupyter), and I'm having issues because we get paths that have mixed slashes from dumpCell, but if we send a request to set a breakpoint in that path, it is not accepted by debugpy unless we normalize the slashes

Example

[Debug] to kernel: {"command":"dumpCell","arguments":{"code":"print(1)\nprint(2)\nprint(3)\nprint(4)\nprint(5)"},"type":"request","seq":8}
[Debug] response: {"type":"response","request_seq":8,"success":true,"command":"dumpCell","body":{"sourcePath":"C:\\Users\\roblou\\AppData\\Local\\Temp/ipykernel_1952/1680877720.py"}}

We can normalize the paths on the client, we were doing that, but it broke down for example when debugging a windows kernel from a non-windows machine. I can also fix that, but really the client should be able to set a breakpoint with the exact path it received without having to transform it.

I'm happy to attempt a PR if you point me in the right direction.

@roblourens
Copy link
Author

Sorry, I picked an environment with an old ipython, and I see this is already fixed in #784

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant