Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Un-expose __file__ and expose __session__ instead. #1095

Merged
merged 1 commit into from
Feb 13, 2023

Conversation

Carreau
Copy link
Member

@Carreau Carreau commented Feb 13, 2023

See jupyter-server/jupyter_server#1198,

setting file will break multiprocessing.

I'm not setting __notebook__ as things that set this value may note be notebooks.

Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@blink1073 blink1073 merged commit 1a486e0 into ipython:main Feb 13, 2023
pentschev added a commit to pentschev/integration that referenced this pull request Feb 13, 2023
As per jupyter-server/jupyter_server#1198
ipykernel version 6.21.0, 6.21.1 were broken when running with
multiprocessing module. As of 6.21.2 this is now fixed by
ipython/ipykernel#1095 .
datapane-ci-bot pushed a commit to datapane/datapane that referenced this pull request Feb 22, 2023
…le from ipykernel

dunder-file was in play for 2 patch versions.
See here: ipython/ipykernel#1095
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants